Skip to content

Conversation

dsabsay
Copy link
Contributor

@dsabsay dsabsay commented Feb 13, 2025

What this PR does:
Updates Ubuntu actions runners.

Which issue(s) this PR fixes:
Fixes #6582

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dosubot dosubot bot added the ci/cd label Feb 13, 2025
Signed-off-by: Daniel Sabsay <[email protected]>
@dsabsay
Copy link
Contributor Author

dsabsay commented Feb 13, 2025

I'm guessing this is a flaky test:

--- FAIL: TestRing_ShuffleShard_Consistency (8.23s)
    --- FAIL: TestRing_ShuffleShard_Consistency/instances_=_20,_shard_size_=_12,_ring_operation_=_add-instance (0.27s)
        ring_test.go:1981: 
            	Error Trace:	/__w/cortex/cortex/pkg/ring/ring_test.go:1981
            	Error:      	"2" is not less than or equal to "1"
            	Test:       	TestRing_ShuffleShard_Consistency/instances_=_20,_shard_size_=_12,_ring_operation_=_add-instance
        ring_test.go:1982: 
            	Error Trace:	/__w/cortex/cortex/pkg/ring/ring_test.go:1982
            	Error:      	"2" is not less than or equal to "1"
            	Test:       	TestRing_ShuffleShard_Consistency/instances_=_20,_shard_size_=_12,_ring_operation_=_add-instance

Copy link
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 13, 2025
@friedrichg friedrichg merged commit 49e7ca1 into cortexproject:master Feb 13, 2025
17 checks passed
@dsabsay dsabsay deleted the update-ubuntu branch February 13, 2025 15:09
friedrichg pushed a commit that referenced this pull request Jul 9, 2025
Signed-off-by: Daniel Sabsay <[email protected]>
Co-authored-by: Daniel Sabsay <[email protected]>
Signed-off-by: Friedrich Gonzalez <[email protected]>
CharlieTLe pushed a commit to CharlieTLe/cortex that referenced this pull request Jul 9, 2025
Signed-off-by: Daniel Sabsay <[email protected]>
Co-authored-by: Daniel Sabsay <[email protected]>
Signed-off-by: Friedrich Gonzalez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd lgtm This PR has been approved by a maintainer size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Ubuntu image on out GH runners:
2 participants